Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scipy and distutils deprecation warnings #706

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

crisp-snakey
Copy link
Contributor

Scipy 1.8 introduced depraction warnings for importing the submodules of ndimage. The solution is to import the functions directly from the ndimage module itself and not through one of the sub-modules that it is (accidentally) exposed through. Furthermore distutils has been slated for deprecation for quite a while now and will be removed in python 3.12. The utils.py file uses functionality from it to handle various versions of pandas. The distutils LooseVersion functionality is re-exposed through the looseversion package and is supposed to be a drop-in replacement for version the distutils counterpart.

@nkeim
Copy link
Contributor

nkeim commented Jul 29, 2022

Thanks! Looks great. We also need to mention looseversion in doc/installation.rst. Normally I can do this but it requires you to be placing this PR from a different branch (not master). Would you mind doing it instead?

At line 131, to the list of dependencies please add

* `looseversion <https://pypi.org/project/looseversion/>`__

@crisp-snakey
Copy link
Contributor Author

I've listed the dependency in the documentation like you asked.

@nkeim
Copy link
Contributor

nkeim commented Aug 1, 2022

Thanks for this soon-to-be essential contribution!! Merging now.

@nkeim nkeim merged commit 00defed into soft-matter:master Aug 1, 2022
@alessiamarcolini
Copy link

Hi @nkeim is there a timeline for releasing this? :)

@nkeim
Copy link
Contributor

nkeim commented Feb 17, 2023

Hi @alessiamarcolini ! Thank you for your patience. Yes, I've finally had a little time to work on some issues that were blocking a release. Please watch for a release candidate in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants