Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: scipy, Pandas, sklearn compatibility #743

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

nkeim
Copy link
Contributor

@nkeim nkeim commented Nov 22, 2023

Fixes failing tests for latest pandas and scipy.

@nkeim nkeim mentioned this pull request Nov 22, 2023
@nkeim nkeim changed the title MNT: scipy and Pandas compatibility MNT: scipy, Pandas, sklearn compatibility Nov 22, 2023
@nkeim
Copy link
Contributor Author

nkeim commented Nov 23, 2023

This is failing in a very special way on Windows. On that platform, somehow, compute_drift() returns a DataFrame with an int32 index. Obviously this is completely inconsequential and the tests could ignore it… but why is it happening at all?!?

    def test_no_drift(self):
        N = 10
        expected = DataFrame({'x': np.zeros(N), 'y': np.zeros(N)}).iloc[1:]
        expected = expected.astype('float')
        expected.index.name = 'frame'
        expected.columns = ['x', 'y']
        # ^ no drift measured for Frame 0
    
        actual = tp.compute_drift(self.dead_still)
>       assert_frame_equal(actual, expected[['y', 'x']])

@nkeim
Copy link
Contributor Author

nkeim commented Nov 23, 2023

I still plan to merge and create a separate issue for the Windows test failures. Almost no actual users on Windows should be affected by this issue.

@nkeim nkeim merged commit d4ff59f into soft-matter:master Nov 26, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant