Prevent unnecessary trait resolution #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trait resolution (and monomorphization, which can be thought of as a variant of this) is used throughout the FSA algorithm (e.g. checking if
T
implementsSend
/Sync
, resolving calls to trait methods to their concrete implementation, etc). Unfortunately this can be slow, particularly during a MIR pass, where functions must be monomorphized on demand. This slowdown becomes particularly apparent when trying to extend FSA to look into other function calls which are reachable via drop. On large codebases like rustc (e.g. when bootstrapping) or Alacritty, this can lead to over a 2x slowdown in compile time.The good news is that it's fairly easy to fix this. This commit does this using two simple tricks:
Ty
.These two changes are enough to put us back in the range of about 1-2% compile-time slowdown for FSA for
Gc
heavy programs, and almost indistinguishable for programs which don't useGc
.