Fix broken behaviour for NoFinalize trait #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `std::mem::needs_finalize<T>()` would only return `true` if the top-level type required finalizing. This now traverses component types correctly. See `test/ui/gc/needs_finalize.rs` for a detailed list of which types need finalizing. A lot of the refactoring in `needs_drop` comes from breaking changes in upstream.
ltratt
reviewed
Jul 30, 2021
| res | ||
| } | ||
|
|
||
| enum DropCheckType { |
There was a problem hiding this comment.
A maybe-silly question: will this enum only ever have two values? If so, is it a boolean in disguise? [The needs_finalizer check suggests it is, but I might be over-simplifying!]
There was a problem hiding this comment.
It is a bool check in disguise yes. That may change in future because newer versions of rustc seem to have introduced the notion of a significant dropck: same behaviour as dropck but some drop methods can be marked as insignificant with a #[insignificant_drop] attribute.
There was a problem hiding this comment.
Aha, OK, then let's keep the enum!
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
std::mem::needs_finalize<T>()would only returntrueifthe top-level type required finalizing. This now traverses component
types correctly. See
test/ui/gc/needs_finalize.rsfor a detailed listof which types need finalizing.
A lot of the refactoring in
needs_dropcomes from breaking changes inupstream.