Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat base for node editor #56

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Feat base for node editor #56

merged 3 commits into from
Sep 18, 2024

Conversation

c0rtexR
Copy link
Contributor

@c0rtexR c0rtexR commented Sep 18, 2024

Context and Justification 🌍

This PR introduces react-flow as the starting point for building out the editor functionality in the @data-river/editor package. The integration is basic for now and serves as a foundation for further development. Additionally, it adds react-flow to the dashboard in the client project (specifically in dashboard.tsx) within the Remix setup. Lastly, I included default Prettier and VSCode formatting settings to maintain consistency in code style across the project.

closes #19

Modifications 🔧

  1. Added react-flow as an editor in the @data-river/editor package.

    • Basic example of react-flow to kickstart development.
  2. Integrated the editor into the dashboard.tsx in the client project under Remix.

    • The editor now appears in the dashboard as part of the initial UI setup.
  3. Added default Prettier configuration and VSCode formatting settings.

    • This ensures consistent formatting across the project for all contributors.

Contribution Checklist 📋

  • Have you used this PR template?   +2 pts
  • Is this PR focused on a single, clearly defined change?   +5 pts
  • Have you linked the issue(s) this PR resolves?   +5 pts
  • Are your changes well-documented and easy to follow?   +5 pts
  • Have you introduced a new feature?   -4 pts
    • Have you updated/added relevant documentation for it?   +4 pts
    • Have you included tests to ensure it works as expected?   +5 pts
  • Did you alter any core behavior of data-river?   -5 pts
    • Have you tested the changes thoroughly, ensuring no regressions?   +10 pts

@c0rtexR c0rtexR merged commit cadfe64 into development Sep 18, 2024
2 checks passed
@c0rtexR c0rtexR deleted the feat/basic-editor branch September 18, 2024 20:44
@c0rtexR c0rtexR added this to the 0.1.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement a React Flow editor with drag-and-drop, minimap, zoom/pan, and node interaction features.
1 participant