Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading hyper and tokio #44

Merged
merged 2 commits into from
Dec 26, 2020
Merged

Upgrading hyper and tokio #44

merged 2 commits into from
Dec 26, 2020

Conversation

sousandrei
Copy link
Contributor

Trying my hand on upgrading this to the latest versions of hyper and tokio
I need help on converting the Server part though. Client seems to be working smooth

@sousandrei sousandrei marked this pull request as draft December 24, 2020 15:56
@sousandrei sousandrei marked this pull request as ready for review December 24, 2020 17:30
@sousandrei
Copy link
Contributor Author

Figured something out inspired by the code on Hyper itself :D
Accepting feedback 👀

@softprops
Copy link
Owner

Looks neat. I'll have to get up to speed on tokio 1.0

@softprops softprops merged commit 51f36aa into softprops:master Dec 26, 2020
@sousandrei sousandrei deleted the upgrate-tokio-hyper branch December 26, 2020 16:09
@softprops
Copy link
Owner

just a heads up, I published these changes in 0.8.0. thanks for the work on nthis @sousandrei !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants