Add server usage extension trait revised for hyper 1.x #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamjpotts
changed the title
iamjpotts
changed the title
softprops
approved these changes
Jun 10, 2024
iamjpotts
force-pushed
the
20240609-update-server
branch
from
255abe5
to
8e2979e
Compare
|
@softprops i noticed you approved both PRs and merged the readme update PR. Keeping this PR as-is would revert the readme changes from the first PR, not sure if that is what you were expecting or not. In any case, the readme changes that accompany this PR make it consistent with itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyperlocalhad an extension method of hyper'sServer- butServerno longer exists inhyper 1.0, so that extension was removed in a pre-release version ofhyperlocal0.9.This adds a replacement extension, extending
UnixListenerwith aservemethod.This PR is one of two potential resolutions to #70, the other being #73.