Bump fabric example to react-native@0.77.0-rc.3 #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Description * 54710a6 - Added `sourceSets` to the package due to changes in ViewManager function signatures, which are no longer nullable * a20adca - Updated to reflect changes in facebook/react-native#47551, `findHostInstance_DEPRECATED` is now a property of the `default` object instead of being a named export. Modified implementation reads from default and fall back to named export as needed * ac7e786 - Similar change to the software-mansion/react-native-svg#2572 that uses new API to create an association map between JS components and their native implementations, avoiding `codegen` crawling through the entire filesystem for `.mm` files. ## Test plan App with React Native 0.77 (like #3277) should compile and work as expected.
j-piasecki
reviewed
Dec 16, 2024
Fixed in 121c498 EDIT: Now it probably will fail for EDIT2: Oh, they don’t share a common source, it should work. |
jakex7
changed the title
j-piasecki
approved these changes
Dec 18, 2024
1 task
j-piasecki
added a commit
that referenced
this pull request
Dec 20, 2024
…3301) ## Description #3278 and #3277 added support for RN 0.77 where the result of generated java files has changed but those weren't updated in the PRs. This should've been caught by the CI but the `package.json` files weren't listed as paths that would trigger it. This seems wrong, as I would imagine we would like the CI to run when changing dependencies, especially React Native. ## Test plan Build the example app (0.75 old arch) and Fabric example app (0.77, both old and new arch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping
FabricExampleapp toreact-native@0.77.0-rc.3to test with the next React Native version. I'll make all necessary changes to the package in the following PR.