Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate next to main #3303

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Migrate next to main #3303

wants to merge 6 commits into from

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 20, 2024

Description

This PR migrates changed from next branch into main.

Test plan

Most of those commits are deprecations, to check get/set run example on web.

m-bert and others added 4 commits December 20, 2024 10:27
@m-bert @j-piasecki
Deprecate Touchable components (#3260)
82d62c0 
## Description

This PR deprecates `Touchable` components in our repo

## Test plan

Try importing any `Touchable` (or its `props`). After importing look at
the console.

---------

Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
@latekvo @m-bert
Fix TouchableNativeFeedback regression (#3294)
1561c53 
## Description

#3260 introduced a regression to the `Gesture Handlers`'s
`TouchableNativeFeedback` component.
The component used to be a direct reference to the
`TouchableNativeFeedback`, which has a [couple of static
methods](https://reactnative.dev/docs/touchablenativefeedback#methods).
When it was replaced with a function component, the static methods got
removed, leaving only the render function of the
`TouchableNativeFeedback`.

## Test plan

See how the type errors in the
`example/src/release_tests/touchables/index.tsx` are resolved.
@m-bert
Deprecate old API (#3262)
61aaef9 
## Description

This PR deprecates old Gesture Handler API.

## Test plan

Try importing any handler from old API.
@m-bert
[Web] Migrate to get and set (#3263)
8f34660 
In this PR I've migrated our handlers into `get`/`set` functions instead of traditional getters and setters convention (like in `Java`).

Run web example
@m-bert m-bert requested review from j-piasecki and latekvo December 20, 2024 09:38
@m-bert m-bert changed the title Migrate next to main. Migrate next to main Dec 20, 2024
@m-bert m-bert marked this pull request as draft December 20, 2024 09:40
@m-bert m-bert marked this pull request as ready for review December 20, 2024 09:49
@latekvo
Copy link
Contributor

latekvo commented Dec 20, 2024 •
edited
Loading

Do you think it'd make sense to rebase these changes onto main instead of squashing them?
While I don't think it's a big deal, I'm not a big fan of squashing 4 PRs and some other changes together instead of keeping them separate

@m-bert
Copy link
Contributor Author

m-bert commented Dec 20, 2024

Do you think it'd make sense to rebase these changes onto main instead of squashing them?

In our discussion with @j-piasecki we decided that it would be better to cherry-pick those changes into separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki Awaiting requested review from j-piasecki

@latekvo latekvo Awaiting requested review from latekvo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @latekvo