Resolve pod conflict #1775
Merged
Resolve pod conflict #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymon20000
approved these changes
Mar 2, 2021
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
## Summary The `Check Expo dev-client nightly build` CI (https://github.com/software-mansion/react-native-reanimated/actions/runs/6016772546) fails with error: ```bash ❌ /Users/runner/work/react-native-reanimated/react-native-reanimated/app/ node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ WorkletRuntimeDecorator.cpp:59:3: use of undeclared identifier 'jsi_utils' jsi_utils::installJsiFunction( ``` This PR fixes the issue of header name conflict with expo-dev-client. The Expo package includes its own JsiUtils.h file, which leads to a collision in header mapping within Xcode. To resolve this problem, we have three possible options: - Use an absolute import path (doesn't work on Android). - Rename JsiUtils.h (as done in this PR). - Utilize namespace imports like #include <Reanimated/...>. In the past we encountered similar issue with Xcode flat header mapping - #1775 Fixes #5002 ## Test plan Check CI status: https://github.com/software-mansion/react-native-reanimated/actions/runs/6034169391?pr=5010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem very well described here (Freeform description section)
Possible solution
preserved_paths