Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 3.0.0-rc.9 , useAnimatedScrollHandler with FlashList not working #3938

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Fix: 3.0.0-rc.9 , useAnimatedScrollHandler with FlashList not working #3938

merged 2 commits into from
Jan 17, 2023

Conversation

orekasep
Copy link
Contributor

@orekasep orekasep commented Jan 12, 2023 •
edited by tomekzaw
Loading

Summary

Fixes #3937.

Test plan

This was referenced Jan 12, 2023
Closed
Closed
graszka22
graszka22 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@graszka22 graszka22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it fixes the issue 👍 Just update the comment please.

src/createAnimatedComponent.tsx Outdated
@@ -196,7 +196,7 @@ export default function createAnimatedComponent(

if (componentName?.endsWith('FlashList') && this._component) {
// @ts-ignore it's FlashList specific: https://github.com/Shopify/flash-list/blob/218f314e63806b4fe926741ef73f8b9cd6ebc7eb/src/FlashList.tsx#L824
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will update shortly

@orekasep orekasep closed this Jan 12, 2023
@orekasep orekasep reopened this Jan 12, 2023
@orekasep
Copy link
Contributor Author

Waiting for a merge

@hamdij0maa
Copy link

still not working on React native 0.71.0

@tomekzaw
Copy link
Member

tomekzaw commented Jan 17, 2023 •
edited
Loading

still not working on React native 0.71.0

What exactly is the problem? Which version are you using? I think you confirmed that this PR works for you in #3937 (comment)

@piaskowyk piaskowyk merged commit 619b3f4 into software-mansion:main Jan 17, 2023
@hamdij0maa
Copy link

still not working on React native 0.71.0

What exactly is the problem? Which version are you using? I think you confirmed that this PR works for you in #3937 (comment)

reanimated : 2.14.1 bug on android, RN 0.71.0

piaskowyk pushed a commit that referenced this pull request Jan 17, 2023
@orekasep @piaskowyk
Fix: 3.0.0-rc.9 , useAnimatedScrollHandler with FlashList not working (…
c2f056f 
…#3938)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Fixes #3937.

## Test plan

<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->

Co-authored-by: Thanh Tran <thanh@lhts.io>
@NTag
Copy link

NTag commented Jan 23, 2023

Actually it works in debug, but on a production build (minified) it doesn't work, the onScroll handler is never called 🥲

@tomekzaw
Copy link
Member

@NTag that's bad news, can you please check if #3988 fixes the release mode?

@graszka22
Copy link
Member

@NTag I tested the main reanimated branch on Android device in release mode, with FlashList and RefreshControl and it works for me.

@NTag
Copy link

NTag commented Jan 23, 2023

I only test the rc10, it may have been fixed then! Happy to try once the latest commits are in a rc11.

@tomekzaw
Copy link
Member

@NTag you can always try nightly build from our main branch: https://github.com/software-mansion/react-native-reanimated/actions/runs/3986157247

fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@orekasep @fluiddot
Fix: 3.0.0-rc.9 , useAnimatedScrollHandler with FlashList not working (…
1b6d77f 
…software-mansion#3938)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Fixes software-mansion#3937.

## Test plan

<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->

Co-authored-by: Thanh Tran <thanh@lhts.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@hamdij0maa hamdij0maa hamdij0maa approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

@graszka22 graszka22 graszka22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useAnimatedScrollHandler not working on Android with RefreshControl version 2.14.1
6 participants
@orekasep @hamdij0maa @tomekzaw @NTag @graszka22 @piaskowyk