Rewrite jest unit tests to TypeScript #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Apr 25, 2023
| style: Record<string, unknown>[] | Record<string, unknown> | ||
| style: Record<string, unknown>[] | Record<string, unknown>, | ||
| config?: { | ||
| shouldMatchAllProps?: boolean; |
There was a problem hiding this comment.
this looks like a breaking change for library users, we'll need to discuss it with the team
tomekzaw
approved these changes
Apr 25, 2023
|
we wait with mergele |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary - Renamed all tests with their respective TypeScript counterparts. - Fixed jestUtils to properly allow strict checking of AnimatedStyle. - Added type declaration emitting to plugin. - Moved building plugin files before running TypeScript on the project (otherwise TypeScript tests would fail during type-checking). - Added test for jestUtils. - Bumped `jest` version and added `@types/react-test-renderer`. --- Added to `jest-setup.js`: ```diff + delete global.MessageChannel; ``` This line is coming from `react-16-node-hanging-test-fix`. It fixes an error of open handles in `@testing-library/react-native` function `render` and jest going 😵. [Reference](facebook/react#20756). ## Test plan `yarn && yarn jest --detectOpenHandles` ftw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jestversion and added@types/react-test-renderer.Added to
jest-setup.js:+ delete global.MessageChannel;This line is coming from
react-16-node-hanging-test-fix. It fixes an error of open handles in@testing-library/react-nativefunctionrenderand jest going 😵. Reference.Test plan
yarn && yarn jest --detectOpenHandlesftw