Fix sensors on android web #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstach60161
force-pushed
the
@mstach60161/fix-android-web-sensors
branch
from
2c70854
to
a57b2c3
Compare
mstach60161
force-pushed
the
@mstach60161/fix-android-web-sensors
branch
from
a57b2c3
to
1abd6a3
Compare
mstach60161
force-pushed
the
@mstach60161/fix-android-web-sensors
branch
from
59f8bf2
to
ed1d4d0
Compare
tomekzaw
reviewed
May 29, 2023
tomekzaw
reviewed
Jun 6, 2023
tomekzaw
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Tested on iOS and Android, looks like finally it's consistent. Thanks @mstach60161 for taking care of this!
Edit: I've tested pitch, roll and yaw between main and this branch and they are the same but I haven't checked qx, qy, qz and qw individually, is this the expected result?
Edit 2: Ready to merge.
Latropos
pushed a commit
that referenced
this pull request
Jun 20, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary ### Problem Android devices use a right-handed coordinate system, where the positive x-axis points to the right, the positive y-axis points up, and the positive z-axis points out of the screen. However iOS uses a left-handed coordinate system, where the positive x-axis points to the right, the positive y-axis points down, and the positive z-axis points into the screen. This is already fixed on android native code, but the problem still exists on android web browser (react native web). ### Fix - Replace quaternion z, y and negate z - Do the same thing on Android native ## Test plan - Web Example App
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Android devices use a right-handed coordinate system, where the positive x-axis points to the right, the positive y-axis points up, and the positive z-axis points out of the screen.
However iOS uses a left-handed coordinate system, where the positive x-axis points to the right, the positive y-axis points down, and the positive z-axis points into the screen.
This is already fixed on android native code, but the problem still exists on android web browser (react native web).
Fix
Test plan