Fix "withDecay clamps position to the wrong boundary" #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
previously approved these changes
Jun 20, 2023
tomekzaw
reviewed
Jun 21, 2023
src/reanimated2/animation/decay.ts
Outdated
| @@ -38,6 +38,7 @@ export interface InnerDecayAnimation | |||
| current: number; | |||
| } | |||
|
|
|||
| const EPSILON = 0.01; | |||
There was a problem hiding this comment.
Isn't it too much? What about 1e-3?
There was a problem hiding this comment.
@Latropos I know that you discussed this with Tomek offline, but let's write the conclusion in a comment to keep the informations in one place, please 🙏
There was a problem hiding this comment.
Sure! We want to have similar precision for decay and withSpring. Also we have tested, that it works well with const EPSILON = 0.01; and that we animate static spring for long time if epsilon is smaller.
tomekzaw
reviewed
Jun 21, 2023
piaskowyk
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4508
Bug description
Screen.Recording.2023-06-20.at.11.27.36.mov
Screen.Recording.2023-06-26.at.16.48.00.mov
Description of code change
I've removed a condition updating the derivative only when square is within predefined boundaries - since we want to keep its springified movement even if it is overshooting. Especially that we used to end animation almost immediately after exceeding limits.
Since after this change the
derivativeis always modified we should no longer compare it to zero, but use some epsilon instead.Test plan
I've tested it on this example: https://github.com/MatiPl01/reanimated-issues, linked in the issue.