Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store last reanimated root as atomic ptr, avoid copying and locking #4813

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Store last reanimated root as atomic ptr, avoid copying and locking #4813

merged 1 commit into from
Aug 7, 2023

Conversation

michalmaka
Copy link
Contributor

Summary

Let's store last reanimated root in PropsRegistry as atomic pointer.
This will let us get rid of additional std::shared_ptr copy and will be more thread-safe.

Test plan

None

@tomekzaw tomekzaw self-requested a review July 27, 2023 11:14
@piaskowyk piaskowyk self-requested a review August 1, 2023 10:12
tomekzaw
tomekzaw approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 👍

@tomekzaw tomekzaw added this pull request to the merge queue Aug 7, 2023
Merged via the queue into software-mansion:main with commit 61c0f6c Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalmaka @tomekzaw