Restore missing API #4847
Merged
Restore missing API #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latropos
approved these changes
Aug 4, 2023
Comment on lines
402
to
403
| // What is this type??? | ||
| // Well we exported it before so let's keep it for now. |
There was a problem hiding this comment.
XD
Suggested change
| // What is this type??? | |
| // Well we exported it before so let's keep it for now. | |
| // This is only legacy type exported to keep the backwards compatibility |
piaskowyk
approved these changes
Aug 4, 2023
Comment on lines
402
to
403
| // What is this type??? | ||
| // Well we exported it before so let's keep it for now. |
There was a problem hiding this comment.
Just change this comment to something more formal 😅
piaskowyk
pushed a commit
that referenced
this pull request
Aug 4, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary During removal of `react-native-reanimated.d.ts` in #4519 I didn't consider that some types were exported only in the aforementioned file, e.g. `WithSpringConfig`. Therefore when we released `3.4.0` those types disappear from public API. This PR restores lacking types from `.d.ts` - but only the relevant ones, without Reanimated1 API. ## Types restored ### namespace Animated - Extrapolate - DerivedValue - Adaptable - TransformStyleTypes - AdaptTransforms - AnimatedTransform - AnimateStyle - StylesOrDefault - AnimateProps - EasingFunction - addWhitelistedNativeProps - addWhitelistedUIProps - AnimatedScrollViewProps - FlatListPropsWithLayout ### react-native-reanimated - Adaptable - AdaptTransforms - AnimatedTransform - TransformStyleTypes - AnimateStyle - StylesOrDefault - AnimatedScrollViewProps - FlatListPropsWithLayout - \-\-\- - EasingFunction - EasingFunctionFactory - \-\-\- - WithDecayConfig - \-\-\- - WithSpringConfig - \-\-\- - WithTimingConfig - \-\-\- - FlatListPropsWithLayout - \-\-\- - AnimatedScrollViewProps - \-\-\- - AnimatedStyleProp - \-\-\- - InterpolateRGB - InterpolateHSV - \-\-\- - KeyframeProps ___ Requires #4855 ## Test plan CI + 🚀
|
If I have upgraded to |
|
Yes, you shouldn't. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Removal of `react-native-reanimated.d.ts` exposed some of our internal API with `export * from ...`. This file limits the exports and (kind-of) defines public API. Requires #4847. ## Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During removal of
react-native-reanimated.d.tsin #4519 I didn't consider that some types were exported only in the aforementioned file, e.g.WithSpringConfig. Therefore when we released3.4.0those types disappear from public API. This PR restores lacking types from.d.ts- but only the relevant ones, without Reanimated1 API.Types restored
namespace Animated
react-native-reanimated
Requires #4855
Test plan
CI + 🚀