Allow nullables in useAnimatedRef scrollable node getters #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Aug 4, 2023
piaskowyk
approved these changes
Aug 4, 2023
piaskowyk
pushed a commit
that referenced
this pull request
Aug 4, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary ~~In types of `react-native` we can see that `getNativeScrollRef` and `getScrollableNode` could return `null` or `undefined`. This PR makes this acknowledged in `useAnimatedRef`.~~ Since #4873 cast new light on how these types should be I checked how are those methods typed in `react-native` and seeing it we decided simply to use `any` since it seems like the only safe option currently. <details> <summary>pic rel</summary>  </details> ## Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In types ofreact-nativewe can see thatgetNativeScrollRefandgetScrollableNodecould returnnullorundefined. This PR makes this acknowledged inuseAnimatedRef.Since #4873 cast new light on how these types should be I checked how are those methods typed in
react-nativeand seeing it we decided simply to useanysince it seems like the only safe option currently.pic rel
Test plan
CI