Add isWorklet function
#4894
Merged
Add isWorklet function
#4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
reviewed
Aug 10, 2023
piaskowyk
approved these changes
Feb 5, 2024
Latropos
reviewed
Feb 5, 2024
tomekzaw
commented
Feb 6, 2024
|
Waits to be merged after 3.7.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
isWorkletfunction which is meant to be used internally as well as by other libraries in order to check whether the input value is a worklet (i.e. is a function with__workletHashproperty added by Reanimated Babel plugin).Once worklet types are fixed,
isWorkletshould mark the input value as worklet, i.e. we'll need to change its signature toexport function isWorklet(value: unknown): value is WorkletType.EDIT from @tjzel:
In order to be able to use the new function
isWorkletproperly I had to fix a bunch of types with regard to worklet types.Test plan
Check that TS CI passes and all the ifs with
.__workletHashwere changed properly.