-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cleaning layout animation config on iOS #4997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO BE REVIEWED
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original source of this issue was this line:
removeAnimationsFromSubtree:(REAUIView *)container
Since container represents an entire screen stack, every layout animation config for that stack is being removed after a screen change. Instead, we should only remove the configuration for the specific screen from the permanentlyRemovedChildren
.
Summary
Closes #4816
Closes #4516
Fixing issue with react navigation. If given view is inside some view controller and it has layout animation don't remove its animations from subtree
Screen.Recording.2023-08-28.at.15.58.33.mov
Screen.Recording.2023-08-28.at.15.55.52.mov
Test plan
Code: