Fix exporting enums as types and type of global in PlatformChecker #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
piaskowyk
approved these changes
Sep 21, 2023
tjzel
added a commit
that referenced
this pull request
Sep 21, 2023
…5105) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes regression that occurred in #5074. Later on we also have to rethink if we want to promote `Extrapolate` or `Extrapolation` since both are exactly the same and we only use the former. ## Test plan I actually made `Extrapolation` used in our examples so such mistake in the future would be caught on CI (only regarding `Extrapolation` sadly). > [!Note] > I recommend using this > ```json > "editor.tokenColorCustomizations": { > "textMateRules": [ > { > "scope": "entity.name.type.enum", > "settings": { > "foreground": "#a3e577" > } > }, > { > "scope": "entity.name.type.class", > "settings": { > "foreground": "#e8b55e" > } > } > ] > } >``` > In your VSCode settings so Classes, Enums and Types are not in the same color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regression that occurred in #5074.
Later on we also have to rethink if we want to promote
ExtrapolateorExtrapolationsince both are exactly the same and we only use the former.Test plan
I actually made
Extrapolationused in our examples so such mistake in the future would be caught on CI (only regardingExtrapolationsadly).Note
I recommend using this
In your VSCode settings so Classes, Enums and Types are not in the same color.