Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS and ESLint in Examples #5361

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

marmor157
Copy link
Member

Summary

This PR fixes most of the TS and ESLint errors in Examples.

@tjzel tjzel self-requested a review November 10, 2023 15:02
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for fixing this!

app/src/examples/PinExample.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedStyleExample.tsx Outdated Show resolved Hide resolved
app/src/examples/LiquidSwipe/LiquidSwipe.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things that I'd like changed.

app/src/examples/SharedElementTransitions/Card.tsx Outdated Show resolved Hide resolved
app/src/examples/IPodExample.tsx Outdated Show resolved Hide resolved
app/src/examples/IPodExample.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/ImageStack.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/Card.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/FlatList.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/ImageStack.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/ImageStack.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/Modals.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/Profiles.tsx Outdated Show resolved Hide resolved
app/src/examples/LiquidSwipe/LiquidSwipe.tsx Outdated Show resolved Hide resolved
app/src/examples/SharedElementTransitions/FlatList.tsx Outdated Show resolved Hide resolved
@tjzel tjzel added this pull request to the merge queue Dec 7, 2023
Merged via the queue into software-mansion:main with commit 5fd48d2 Dec 7, 2023
6 checks passed
Latropos pushed a commit that referenced this pull request Dec 12, 2023
## Summary
This PR fixes most of the TS and ESLint errors in Examples.

---------

Co-authored-by: Tomasz Żelawski <tomasz.zelawski@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants