Fix undefined config in podspec
#5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Nov 21, 2023
tomekzaw
reviewed
Nov 21, 2023
Latropos
pushed a commit
that referenced
this pull request
Nov 24, 2023
## Summary This PR fixes error: ```bash [!] Invalid `Podfile` file: [!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module Did you mean? concerning. # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90 # ------------------------------------------- # gcc_debug_definitions = "$(inherited)" > if config[:react_native_minor_version] >= 73 || !is_release # gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1" # ------------------------------------------- . # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31 # ------------------------------------------- # target 'ReanimatedExample' do > config = use_native_modules! # # ------------------------------------------- ``` Related to PRs: #5383 and #5334 It is because we renamed `config` to global variable `$config` ## Test plan Build Example app --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos
pushed a commit
that referenced
this pull request
Dec 12, 2023
## Summary This PR fixes error: ```bash [!] Invalid `Podfile` file: [!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module Did you mean? concerning. # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90 # ------------------------------------------- # gcc_debug_definitions = "$(inherited)" > if config[:react_native_minor_version] >= 73 || !is_release # gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1" # ------------------------------------------- . # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31 # ------------------------------------------- # target 'ReanimatedExample' do > config = use_native_modules! # # ------------------------------------------- ``` Related to PRs: #5383 and #5334 It is because we renamed `config` to global variable `$config` ## Test plan Build Example app --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos
pushed a commit
that referenced
this pull request
Dec 19, 2023
This PR fixes error: ```bash [!] Invalid `Podfile` file: [!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module Did you mean? concerning. # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90 # ------------------------------------------- # gcc_debug_definitions = "$(inherited)" > if config[:react_native_minor_version] >= 73 || !is_release # gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1" # ------------------------------------------- . # from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31 # ------------------------------------------- # target 'ReanimatedExample' do > config = use_native_modules! # # ------------------------------------------- ``` Related to PRs: #5383 and #5334 It is because we renamed `config` to global variable `$config` Build Example app --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes error:
Related to PRs: #5383 and #5334
It is because we renamed
configto global variable$configTest plan
Build Example app