Allow different flavors JS and App #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Nov 24, 2023
tomekzaw
requested changes
Nov 24, 2023
piaskowyk
approved these changes
Nov 24, 2023
tomekzaw
approved these changes
Nov 24, 2023
Latropos
pushed a commit
that referenced
this pull request
Nov 24, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->
## Summary
tl;dr
## Test plan
### To make DEBUG bundle in RELEASE app
in `metro/Server.js` add
```js
transformOptions.dev = true;
```
below
```js
async build(options) {
const {
entryFile,
graphOptions,
onProgress,
resolverOptions,
serializerOptions,
transformOptions,
} = splitBundleOptions(options);
```
and add `RCT_DEV=1` flag to pods in XCode
### To make RELEASE bundle in DEBUG app
```
Manually create release bundle with Metro, put it as e.g. `CUSTOM_BUNDLE.jsbundle` in `ios` and load it from file in AppDelegate.mm like this:
```mm
//#if DEBUG
// return [[RCTBundleURLProvider sharedSettings]
jsBundleURLForBundleRoot:@"index"];
//#else
return [[NSBundle mainBundle] URLForResource:@"CUSTOM_BUNDLE"
withExtension:@"jsbundle"];
//#endif
```
```
---------
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Latropos
pushed a commit
that referenced
this pull request
Dec 12, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->
## Summary
tl;dr
## Test plan
### To make DEBUG bundle in RELEASE app
in `metro/Server.js` add
```js
transformOptions.dev = true;
```
below
```js
async build(options) {
const {
entryFile,
graphOptions,
onProgress,
resolverOptions,
serializerOptions,
transformOptions,
} = splitBundleOptions(options);
```
and add `RCT_DEV=1` flag to pods in XCode
### To make RELEASE bundle in DEBUG app
```
Manually create release bundle with Metro, put it as e.g. `CUSTOM_BUNDLE.jsbundle` in `ios` and load it from file in AppDelegate.mm like this:
```mm
//#if DEBUG
// return [[RCTBundleURLProvider sharedSettings]
jsBundleURLForBundleRoot:@"index"];
//#else
return [[NSBundle mainBundle] URLForResource:@"CUSTOM_BUNDLE"
withExtension:@"jsbundle"];
//#endif
```
```
---------
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tl;dr
Test plan
To make DEBUG bundle in RELEASE app
in
metro/Server.jsaddbelow
and add
RCT_DEV=1flag to pods in XCodeTo make RELEASE bundle in DEBUG app