Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of _log function #5436

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix type of _log function #5436

merged 1 commit into from
Nov 30, 2023

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Nov 30, 2023 •
edited
Loading

Summary

This PR fixes the type of argument of _log function.

Test plan

_log(42);

@tomekzaw tomekzaw requested a review from tjzel November 30, 2023 12:36
tjzel
tjzel approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid pull request. I wish all of them were so thorough.

@tomekzaw tomekzaw added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 9edf9f0 Nov 30, 2023
7 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/fix-log-type branch November 30, 2023 13:54
piaskowyk pushed a commit that referenced this pull request Nov 30, 2023
@tomekzaw @piaskowyk
Fix type of _log function (#5436)
92b120b 
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

This PR fixes the type of argument of `_log` function.

## Test plan

```ts
_log(42);
```
Latropos pushed a commit that referenced this pull request Dec 12, 2023
@tomekzaw
Fix type of _log function (#5436)
79745b4 
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

This PR fixes the type of argument of `_log` function.

## Test plan

```ts
_log(42);
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @tjzel