Use relative file location in source maps with relativeSourceLocation enabled
#5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This option was added back when source maps were not included in #3141.
Source map addition for better LogBox experience was added in #3846 - but it didn't take into account
relativeSourceLocation. This PR fixes this and there is no more absolute location in the source map whilerelativeSourceLocationis on.I haven't found a way to generate the source map with relative location out-of-the-box.
Test plan
In
WorkletExamplesee that LogBox is working as intended. Also plugin tests maybe.