Fix transform in exiting animation #5470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, if element has any
transform
(for exampletranslateX
), exiting won't work correctly. This happens because during animations we write transform directly into components' style to avoid problems with delay. On the other hand, exiting works withsnapshots
which already take care about components position, including transforms.In order to fix that we can ignore creating animation with transform and reset
dummy.style.transform
.Test plan
Test code