Setup custom eslint plugin #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
January 4, 2024 16:13
Latropos
commented
Feb 2, 2024
|
If you're adding this and it's supposed to be a part of our public API you should also acknowledge it in the docs. |
|
@tjzel Yes, but we probably should publish it before adding documentation and we also shouldn't make this PR too big. |
|
Why though? If it's tested sufficiently then I see no reason to add the docs immediately. Also change in the docs is independent of the code you already made, that's not really bloating this PR. |
|
@tjzel |
added 2 commits
February 7, 2024 15:17
|
Ah, then nvm my rant 😅 🤯 |
tjzel
requested changes
Feb 7, 2024
Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tjzel
reviewed
Feb 12, 2024
__tests__/eslintPlugin/noAnimatedStyleToNonAnimatedComponent.test.tsx
Outdated
Show resolved
Hide resolved
|
@tjzel 
|
Latropos
force-pushed
the
acynk/eslint-plugin
branch
from
e3b15f7
to
689d160
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
## Summary With #5553 were merged unnecessary changes in `app/yarn.lock`. Cause: `esbuild` from `eslintPlugin/package.json` was moved from `dependency` to `devDependency` without regeneration of `app/package.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setup custom eslint plugi with one rule - no animated style in non animated component. This rule is turned on in example app.
Test plan