feat: add visionos support #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get what's wrong with this import 🤔 Validate iOS CI is showing this:
|
|
Thank for the PR! 😍 and don't worry about CI, I'll check it 🫡 |
okwasniewski
commented
Feb 2, 2024
okwasniewski
force-pushed
the
feat/visionos
branch
from
76bca80
to
ba8e581
Compare
Looks like it was related to the order of imports, moving |
j-piasecki
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Feb 5, 2024
## Description This PR adds support for visionOS platform. Based on software-mansion/react-native-reanimated#5627. ## Test plan ``` npx @callstack/react-native-visionos@latest init VisionApp yarn add software-mansion-labs/react-native-gesture-handler#@tomekzaw/visionos cd visionos pod install ```
tomekzaw
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
visionossupport. I've refactored call sites toUIApplication.sharedApplication.keyWindow(it's unavailable on visionOS) forRCTKeyWindow()its a React Native core utility for retrieving key window. (In one of my recent PRs it got support for multi-window scenarios: facebook/react-native#42036)CleanShot.2024-02-01.at.17.06.55.mp4
Test plan
npx @callstack/react-native-visionos@latest init MyApp"react-native-reanimated": "git@github.com:okwasniewski/react-native-reanimated.git#feat/visionos",