Fix default Sensor interval causing a security exception #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Mar 21, 2024
android/src/main/java/com/swmansion/reanimated/sensor/ReanimatedSensor.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/sensor/ReanimatedSensor.java
Outdated
Show resolved
Hide resolved
tomekzaw
changed the title
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
piaskowyk
approved these changes
Mar 25, 2024
latekvo
changed the title
|
This PR fixed both the magnetic and the accelerometer sensor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently default magnetic sampling interval equals 2ms, which triggers a
HIGH_SAMPLE_RATEsecurity exception.This fix defaults the probing interval to 8ms.
Note:
'auto'setting defaults to-1, which is then replaced by2.Test plan
Download a new emulator on Android Studio - I'm using
Pixel 8 UpsideDownCakeLaunch the magnetic sensor example before, and after applying this patch.