Replace systemUptime calls with CACurrentMediaTime() to comply with Apple privacy requirements
#5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
systemUptime calls with CACurrentMediaTime()
tomekzaw
changed the title
systemUptime calls with CACurrentMediaTime()systemUptime calls with CACurrentMediaTime() to comply with Apple privacy requirements
piaskowyk
approved these changes
Mar 21, 2024
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 15, 2024
This unfortunately causes a peer-dep warning:
warning " > @react-navigation/material-top-tabs@6.6.13" has
incorrect peer dependency "@react-navigation/native@^6.0.0".
But no issues have yet appeared in manual testing, and that's
consistent with the note on the React Navigation upgrade guide that
says, "To make upgrading easier, it is possible to mix packages from
the `6.x.x` and `5.x.x` version ranges.":
https://reactnavigation.org/docs/upgrading-from-5.x#note-on-mixing-react-navigation-5-and-react-navigation-6-packages
Changelog:
https://github.com/react-navigation/react-navigation/blob/main/packages/material-top-tabs/CHANGELOG.md
Done by reading and following the relevant parts of the React Nav
upgrade guide, including general information at the top and also the
section specific to Material Top Tabs:
https://reactnavigation.org/docs/upgrading-from-5.x/#material-top-tab-navigator
Done now because it lets us get rid of react-native-reanimated, as
foreshadowed in our React Nav 6 upgrade issue:
zulip#4936 (comment)
That's helpful because the old version of react-native-reanimated
that we're on uses a certain iOS API that Apple identifies as
privacy-sensitive, triggering a "Privacy Manifest" requirement:
software-mansion/react-native-reanimated#5819
For zulip#5847, we're working on reducing and handling such requirements.
That API usage is removed in v2.9.0-rc.0 of Reanimated (see
just-linked PR), but I didn't pursue upgrading it because that path
seems to require abandoning remote JS debugging, at least according
to a note from 2022. For details on that, search for
"react-native-reanimated" here:
zulip#5441
Related: zulip#5847
Fixes-partly: zulip#4936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5801.
This PR replaces all
[[NSProcessInfo processInfo] systemUptime]calls withCACurrentMediaTime() * 1000.Test plan
Check if
useAnimatedSensorwith interval works properly.