Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useScrollViewOffset docs #5824

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

szydlovsky
Copy link
Contributor

@szydlovsky szydlovsky commented Mar 21, 2024

Summary

useScrollViewOffset hook got a web support, so I bumped REA in docs and changed the example to showcase its features more strikingly.

Screen.Recording.2024-03-21.at.15.10.25.mov

Test plan

Open docs page for useScrollViewOffset.

docs/docs/scroll/useScrollViewOffset.mdx Outdated Show resolved Hide resolved
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm approving in advance but please address all the comments

docs/src/examples/ScrollViewOffset.jsx Outdated Show resolved Hide resolved
docs/src/examples/ScrollViewOffset.jsx Outdated Show resolved Hide resolved
docs/docs/scroll/useScrollViewOffset.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my concerns were already addressed by Kacper -> self-closing tag and variable naming conventions, also approving in advance

docs/docs/scroll/useScrollViewOffset.mdx Outdated Show resolved Hide resolved
@szydlovsky szydlovsky requested a review from tjzel March 25, 2024 13:46
docs/docs/scroll/useScrollViewOffset.mdx Outdated Show resolved Hide resolved
@szydlovsky szydlovsky added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit d224237 Mar 25, 2024
7 checks passed
@szydlovsky szydlovsky deleted the @szydlovsky/useScrollViewOffset-docs-improvements branch March 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants