Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getAnimatableRef on web #6088

Merged
merged 3 commits into from
Jun 11, 2024
Merged

fix: getAnimatableRef on web #6088

merged 3 commits into from
Jun 11, 2024

Conversation

intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Jun 7, 2024 •
edited
Loading

Summary

#4533 added support for getAnimatableRef. Tried testing it for this issue but found it was not working for web.

Test plan

getAnimatableRef should work on web.

@intergalacticspacehighway intergalacticspacehighway mentioned this pull request Jun 7, 2024
Merged
3 tasks
@tomekzaw
Copy link
Member

tomekzaw commented Jun 7, 2024

Thanks for the PR! We will prioritize this. I hope we can get this reviewed and merged early next week.

@tomekzaw tomekzaw requested a review from m-bert June 7, 2024 14:11
m-bert
m-bert approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@piaskowyk piaskowyk added this pull request to the merge queue Jun 11, 2024
Merged via the queue into software-mansion:main with commit fe0b50e Jun 11, 2024
6 checks passed
@intergalacticspacehighway intergalacticspacehighway deleted the fix/get-animatable-ref-web branch June 11, 2024 09:13
This was referenced Jul 25, 2024
Open
Open
Open
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@intergalacticspacehighway @tomekzaw @piaskowyk @m-bert