Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing colors #6193

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Testing colors #6193

merged 1 commit into from
Jul 2, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 1, 2024 •
edited
Loading

Summary

Improve experience of creating new tests of colors, reuse logic to normalize color instead of requireing passing them in unified form.

Test plan

  • The tests don't crash when you provide color that isn't hex (like rgb(123,45,67) or yellow)
  • The tests don't pass when you provide invalid color (like 123456 without "#")

@Latropos Latropos marked this pull request as ready for review July 1, 2024 14:08
szydlovsky
szydlovsky approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice improvement!

@Latropos Latropos enabled auto-merge July 2, 2024 10:07
@Latropos Latropos added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 4115e83 Jul 2, 2024
6 checks passed
@Latropos Latropos deleted the acynk/testing-colors branch July 2, 2024 10:11
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Latropos @piaskowyk @szydlovsky