Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer waitForAnimationUpdates over wait #6291

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Prefer waitForAnimationUpdates over wait #6291

merged 2 commits into from
Jul 18, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 18, 2024 •
edited
Loading

Summary

Prefer waitForAnimationUpdates over wait to make the animation faster and more reliable

Test plan

@Latropos Latropos marked this pull request as ready for review July 18, 2024 12:13
piaskowyk
piaskowyk approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Latropos Latropos added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 59fec2d Jul 18, 2024
5 checks passed
@Latropos Latropos deleted the acynk/prefer-waitForAnimationUpdates branch July 18, 2024 13:38
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Latropos @piaskowyk