Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - don't require render in every test #6318

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 23, 2024

Summary

Since the very beginning of testing framework we had the following bug - if a given test doesn't include any render then the tests freeze. After debugging I've found that we should have initiated _wasRenderedNull with the opposite value:

- private _wasRenderedNull: boolean = false;
+ private _wasRenderedNull: boolean = true;

Test plan

@Latropos Latropos marked this pull request as ready for review July 23, 2024 12:38
@Latropos Latropos added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 183add4 Jul 26, 2024
5 checks passed
@Latropos Latropos deleted the acynk/dont-require-render branch July 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants