Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReanimatedHiddenHeaders, LoggerInterface and SpeedChecker #6363

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Remove ReanimatedHiddenHeaders, LoggerInterface and SpeedChecker #6363

merged 3 commits into from
Aug 1, 2024

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jul 31, 2024 •
edited by github-actions bot
Loading

Summary

This PR removes some rusty and unused parts of the code like SpeedChecker as well as removes Logger and LoggerInterface in favor of static PlatformLogger which also enables us to finally get rid of ReanimatedHiddenHeaders and hidden_headers along with its configuration in CMakeLists.txt and RNReanimated.podspec.

Test plan

@tomekzaw tomekzaw requested review from tjzel and piaskowyk July 31, 2024 15:32
@tjzel tjzel added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit f26aebb Aug 1, 2024
13 checks passed
@tjzel tjzel deleted the @tomekzaw/remove-hidden-headers branch August 1, 2024 12:20
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Open
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @tjzel