Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mark debugging docs as unreleased, remove recommended metro config step #6529

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Sep 20, 2024

Summary

This PR removes confusing docs merged before changes related do the logger/metro config are released. I removed the metro config recommended step from quick start to prevent confusion (as in the #6507 issue) and marked respective pages in docs as unreleased on the sidebar and by using the info box on docs pages.

Screenshot 2024-09-20 at 16 17 58

Test plan

Just start the docs and see that there is no more recommended metro config step and see unreleased labels near debugging docs pages.

@MatiPl01 MatiPl01 self-assigned this Sep 20, 2024
@MatiPl01 MatiPl01 requested a review from tjzel September 20, 2024 14:21
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seinfeld Cigar

@MatiPl01 MatiPl01 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit d6c0111 Sep 20, 2024
8 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/mark-debugging-docs-unreleased branch September 20, 2024 14:32
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
## Summary

This PR just restores changes I reverted in the #6529 PR. Since now
logger changes are released after `3.16.0` is rolled out, we can restore
the getting start part and remove unreleased labels/info boxes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants