Add interpolateColor worklet #960
Conversation
likern
changed the title
likern
changed the title
|
Unfortunately, I couldn't test these changes using modified react-native-reanimated package because I've got "Unsatisfied Link Error" for reanimated.so. I've tested using javascript playground. If there are maintainers with complete build setup - please, verify this pull-request is working. I think it should.
|
|
Just a tiny note: you do not have to add |
likern
changed the title
|
I have these functions working well I think at https://github.com/wcandillon/react-native-redash/pull/289/files#diff-1234f550d692aff6b8f2a1952daf79ec. Is this helping? |
| type = type || Extrapolate.CLAMP; | ||
|
|
||
| const startColor = destructColor.apply({}, output[0]); | ||
| const endColor = destructColor.appy({}, output[1]); |
There was a problem hiding this comment.
typo, I guess expected word is apply
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like with appy misspell it doesn't work. If I would able to build react-native-reanimated npm package from master branch I'll fix misspell and add tests.
| return undefined; | ||
| } | ||
|
|
||
| const r = interpolate.apply({}, x, input, [startColor[0], endColor[0]], type); |
There was a problem hiding this comment.
shouldn't those args be wrapped in an array like const r = interpolate.apply({}, [x, input, [startColor[0], endColor[0]], type]); ?
There was a problem hiding this comment.
here and for the 3 following calls
There was a problem hiding this comment.
@likern, any update on this?
|
Interpolate color works well with redash worklets: https://github.com/wcandillon/react-native-redash/blob/master/src/Colors.ts#L201 feel free to copy this implementation if needed. |
Description
This PR adds
interpolateColorworklet for Reanimated 2 which interpolates colors in RGBA space.For now there is no way to interpolate colors, only numbers are allowed.
Changes
destructColorfunction which split number color into RGBA chanelsinterpolateColorfunction which interpolates color