-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support for RN 0.73 #1956
Merged
Merged
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8d5b728 - Browse repository at this point
Copy the full SHA 8d5b728View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87309f9 - Browse repository at this point
Copy the full SHA 87309f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d762cc3 - Browse repository at this point
Copy the full SHA d762cc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a319d1 - Browse repository at this point
Copy the full SHA 9a319d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f98b9 - Browse repository at this point
Copy the full SHA e8f98b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 711c5df - Browse repository at this point
Copy the full SHA 711c5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d4dff3 - Browse repository at this point
Copy the full SHA 7d4dff3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 531b611 - Browse repository at this point
Copy the full SHA 531b611View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6074a75 - Browse repository at this point
Copy the full SHA 6074a75View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1ac0bf - Browse repository at this point
Copy the full SHA f1ac0bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f04411 - Browse repository at this point
Copy the full SHA 5f04411View commit details -
Configuration menu - View commit details
-
Copy full SHA for e54b979 - Browse repository at this point
Copy the full SHA e54b979View commit details -
Configuration menu - View commit details
-
Copy full SHA for 007c29f - Browse repository at this point
Copy the full SHA 007c29fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b59a97 - Browse repository at this point
Copy the full SHA 5b59a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66606cc - Browse repository at this point
Copy the full SHA 66606ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 051bc9d - Browse repository at this point
Copy the full SHA 051bc9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 899f6fd - Browse repository at this point
Copy the full SHA 899f6fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f8b7e - Browse repository at this point
Copy the full SHA 70f8b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b80f0a - Browse repository at this point
Copy the full SHA 2b80f0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e13c93 - Browse repository at this point
Copy the full SHA 9e13c93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e0668e - Browse repository at this point
Copy the full SHA 8e0668eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4176d3 - Browse repository at this point
Copy the full SHA b4176d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f4d362 - Browse repository at this point
Copy the full SHA 4f4d362View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e98674 - Browse repository at this point
Copy the full SHA 1e98674View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c6c69 - Browse repository at this point
Copy the full SHA c7c6c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95fc916 - Browse repository at this point
Copy the full SHA 95fc916View commit details -
Configuration menu - View commit details
-
Copy full SHA for 507b0d2 - Browse repository at this point
Copy the full SHA 507b0d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e23288 - Browse repository at this point
Copy the full SHA 4e23288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49bfcdb - Browse repository at this point
Copy the full SHA 49bfcdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e677be7 - Browse repository at this point
Copy the full SHA e677be7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8c524 - Browse repository at this point
Copy the full SHA 3f8c524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a969c6 - Browse repository at this point
Copy the full SHA 0a969c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8571db - Browse repository at this point
Copy the full SHA b8571dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ab475 - Browse repository at this point
Copy the full SHA b9ab475View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2b631b - Browse repository at this point
Copy the full SHA b2b631bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fdfd4a - Browse repository at this point
Copy the full SHA 4fdfd4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f30efa8 - Browse repository at this point
Copy the full SHA f30efa8View commit details
Commits on Nov 16, 2023
-
fix(android): add buildFeatures.buildConfig true for AGP8+ compat (#1966
) ## Summary Upcoming react-native 0.73+ includes android gradle plugin 8+ which needs namespace in build.gradle but also needs buildFeatures.buildConfig enabled as well for modules that use it It is not sufficient to enable this at the top-level app build.gradle, specific modules that use it (such as those that implement new architecture, it seems) must also enable it at the module level This change was necessary and is in-use in my work app via patch-package as I work through android-gradle-plugin 8+ issues in prep for react-native 0.73 launching for everyone It should be backwards compatible with older gradle plugins in the exact same way the previous namespace change was, as it is wrapped in the same conditional It is similar to changes I needed to do as react-native-firebase maintainer --> invertase/react-native-firebase@b52d0ce ## Test Plan ### What's required for testing (prerequisites)? With apologies, you have to alter an app that integrates this module to use android gradle plugin 8, it's difficult to do that in repos I'm proposing these changes in because bumping to android gradle plugin 8 requires a large amount of transitive dependency changes in CI (see #1956 !) I have integrated this in an app and tested it, and done similar work as maintainer of react-native-firebase, react-native-netinfo and react-native-device-info, and I'm now pushing these out to the repos ### What are the steps to reproduce (after prerequisites)? run the build for android --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Configuration menu - View commit details
-
Copy full SHA for 1868f8e - Browse repository at this point
Copy the full SHA 1868f8eView commit details -
doc: add kotlin MainActiviy.kt to instructions (#1971)
## Description RN 0.73 has MainActivity in kotlin not java ## Changes - Updated README.md --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com> Co-authored-by: Tymoteusz Boba <Tymoteusz.Boba@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4a44260 - Browse repository at this point
Copy the full SHA 4a44260View commit details
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8ca2fb - Browse repository at this point
Copy the full SHA c8ca2fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f213c - Browse repository at this point
Copy the full SHA 44f213cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cadb650 - Browse repository at this point
Copy the full SHA cadb650View commit details -
Configuration menu - View commit details
-
Copy full SHA for b73937b - Browse repository at this point
Copy the full SHA b73937bView commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d8e2a9b - Browse repository at this point
Copy the full SHA d8e2a9bView commit details -
fix: build error with rn 0.73-rc.4 (#1972)
## Description Fixes building against react-native 0.73.0-rc4 in fabric mode on android ## Changes Updated common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h to build with fabric on 0.73-rc4. ## Screenshots / GIFs ### Before ### After ## Test code and steps to reproduce ```sh npx react-native@0.73.0-rc4 init rnscreenstest yarn add react-native-screens cd android # change newArchEnabled to true in `gradle.properties` gradlew build ``` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for 3849e2c - Browse repository at this point
Copy the full SHA 3849e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 305ba58 - Browse repository at this point
Copy the full SHA 305ba58View commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 47a7c05 - Browse repository at this point
Copy the full SHA 47a7c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for f491acd - Browse repository at this point
Copy the full SHA f491acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c6bc5 - Browse repository at this point
Copy the full SHA d7c6bc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 852a86b - Browse repository at this point
Copy the full SHA 852a86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 007d67a - Browse repository at this point
Copy the full SHA 007d67aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5321bd9 - Browse repository at this point
Copy the full SHA 5321bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4792e4 - Browse repository at this point
Copy the full SHA e4792e4View commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 962c93c - Browse repository at this point
Copy the full SHA 962c93cView commit details
Commits on Nov 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b812bed - Browse repository at this point
Copy the full SHA b812bedView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.