feat: dont recycle RNScreenView #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix iOS crash on navigating to two screens in the same time
2 tasks
WoLewicki
commented
Mar 20, 2024
tboba
approved these changes
Mar 20, 2024
This was referenced May 22, 2024
This was referenced May 25, 2024
This was referenced Jun 9, 2024
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description PR disabling view recycling from `RNSScreenView` component. It also enables us to fix long lasting issue with view recycling. This feature was added in RN 0.74 and will only work then. Fixes software-mansion#1628. ## Changes - stop recycling `RNSScreenView` - Remove logic connected to problems with view recycling - Change the logic of setting push view controllers on new architecture, when transition is ongoing - Add if check for cases, when user navigates to more than one screen at the same time ## Test code and steps to reproduce See that modals and `replace` action work correctly. You can also use `Test2069.tsx` from FabricTestExample / TestsExample to test the behavior of replacing screens conditionally. --------- Co-authored-by: tboba <tymoteusz.boba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR disabling view recycling from
RNSScreenViewcomponent. It also enables us to fix long lasting issue with view recycling. This feature was added in RN 0.74 and will only work then.Fixes #1628.
Changes
RNSScreenViewTest code and steps to reproduce
See that modals and
replaceaction work correctly. You can also useTest2069.tsxfrom FabricTestExample / TestsExample to test the behavior of replacing screens conditionally.