chore: migrate examples to react-navigation v7 #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
I guess if these are only examples that you detected to have problems we should proceed with merging.
We should just keep in mind, than when testing it might be possible that some tests require porting.
Going through every single example, testing it & wondering whether something needs to be ported is a waste of time for now. I'll write this to backlog, but rn let's move forward.
alduzy
added a commit
that referenced
this pull request
Jun 28, 2024
## Description This PR intents to migrate examples to react-navigation v7. Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/ As for now I have only found ~~two~~ few files that needed changes. I ensured that nothing crashes in the example. ## Changes - migrated navigating to nested screen - replaced `navigate` with `popTo` when explicitly going back to a specific screen - ensured nothing crashes <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 2, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR intents to migrate examples to react-navigation v7. Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/ As for now I have only found ~~two~~ few files that needed changes. I ensured that nothing crashes in the example. ## Changes - migrated navigating to nested screen - replaced `navigate` with `popTo` when explicitly going back to a specific screen - ensured nothing crashes <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to migrate examples to react-navigation v7.
Documentation: https://reactnavigation.org/docs/7.x/upgrading-from-6.x/
As for now I have only found
twofew files that needed changes. I ensured that nothing crashes in the example.Changes
navigatewithpopTowhen explicitly going back to a specific screenTest code and steps to reproduce
Checklist