Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: Using env working directory for cache deps path #2244

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented Jul 10, 2024

Description

This PR intents to use env.WORKING_DIRECTORY in workflow's cache-dependency-path.

Changes

Test code and steps to reproduce

Checklist

  • Ensured that CI passes

@alduzy alduzy marked this pull request as ready for review July 10, 2024 13:48
Copy link
Contributor

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch 🎉

@alduzy alduzy merged commit 0c27805 into main Jul 10, 2024
6 checks passed
@alduzy alduzy deleted the @alduzy/cache-deps-path-from-env branch July 10, 2024 15:30
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…sion#2244)

## Description

This PR intents to use `env.WORKING_DIRECTORY` in workflow's
`cache-dependency-path`.

## Changes

<!--
Please describe things you've changed here, make a **high level**
overview, if change is simple you can omit this section.

For example:

- Updated `about.md` docs

-->

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants