fix(Android): prevent crash with InsetsObserverProxy already registered #2526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Activity restarts do not invalidate JVM state entirely (at least it seems so), therefore InsetsObserverProxy
kept being registered on some decorview between activity restarts (context recreations) leading to crash
(we guard against multiple registrations).
Fixes #2519
Possibly fixes #2507
Changes
InsetsOberverProxy
row registers for context lifecycle, when it's destroyed it cleans its state.Test code and steps to reproduce
Haven't managed to reproduce this myself, but got confirmation in #2507 that this patch works.
Checklist