Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Cargo logs with SpinnerBar::println #1337

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Print Cargo logs with SpinnerBar::println #1337

merged 2 commits into from
Jun 6, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Jun 4, 2024 •
edited
Loading

fix #1336

@maciektr maciektr requested a review from mkaput June 4, 2024 11:17
@maciektr maciektr marked this pull request as draft June 4, 2024 11:19
@maciektr maciektr marked this pull request as ready for review June 4, 2024 11:19
mkaput
mkaput reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be, like, more intelligent?

If there is an active spinner handle:

  1. Do not allow creating other spinners
  2. Redirect all Ui::print & co. calls to this spinner's println

@maciektr maciektr requested a review from mkaput June 5, 2024 09:30
mkaput
mkaput requested changes Jun 5, 2024
View reviewed changes
utils/scarb-ui/src/lib.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/message.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput June 5, 2024 11:32
mkaput
mkaput requested changes Jun 5, 2024
View reviewed changes
scarb/tests/build_cairo_plugin.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/components/spinner.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/widget.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/lib.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/lib.rs Outdated Show resolved Hide resolved
utils/scarb-ui/src/lib.rs Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Jun 6, 2024
View reviewed changes
utils/scarb-ui/src/lib.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput June 6, 2024 09:58
@maciektr maciektr added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit cc470de Jun 6, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/spinner branch June 6, 2024 10:51
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@THenry14 THenry14 Awaiting requested review from THenry14

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output of cargo build for macros is going wild together with the command indicator
2 participants
@maciektr @mkaput