Add Uint64 and Uint128 classes
#1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddoktorski
force-pushed
the
ddoktorski/1235-rpc-0.6.0-u64-u128
branch
2 times, most recently
from
e3b0bf3
to
9ea1d50
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1247 +/- ##
===============================================
+ Coverage 89.03% 98.00% +8.96%
===============================================
Files 89 89
Lines 4487 4502 +15
===============================================
+ Hits 3995 4412 +417
+ Misses 492 90 -402 ☔ View full report in Codecov by Sentry. |
ddoktorski
force-pushed
the
ddoktorski/1235-rpc-0.6.0-u64-u128
branch
from
9ea1d50
to
6a9447e
Compare
THenry14
approved these changes
Jan 10, 2024
ddoktorski
changed the base branch from
ddoktorski/1235-rpc-0.6.0
to
development
ddoktorski
force-pushed
the
ddoktorski/1235-rpc-0.6.0-u64-u128
branch
from
6a9447e
to
be5f2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1235 and #1243
Introduced changes
Uint64andUint128used for correct serialization/deserialization of RPCu64andu128typesNumberAsHexclass, from which theFelt,Uint64andUint128classes can inherit. As a result, regex pattern checking has now been added to theFelttypeTransactionV3Schemato createdictof common fields for broadcasted transaction v3, ideally we should implement similar approach for all transactions