Add warning message to Windows installation section #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1257 +/- ##
============================================
Coverage 98.00% 98.00%
============================================
Files 89 89
Lines 4506 4506
============================================
Hits 4416 4416
Misses 90 90 |
tkumor3
force-pushed
the
1173-update-windows-install
branch
from
e46505d
to
00e6692
Compare
THenry14
approved these changes
Jan 23, 2024
ddoktorski
reviewed
Jan 23, 2024
ddoktorski
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Apart from a small nitpick about rephrasing, would you mind formatting the PR titles (and therefore commit messages in the development branch) to start with a capital letter and be in the imperative mood? Also, it would be great if we could include a 'Closes...' directive in the PR's description.
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
tkumor3
changed the title
tkumor3
changed the title
tkumor3
changed the title
tkumor3
changed the title
tkumor3
changed the title
ddoktorski
reviewed
Jan 23, 2024
ddoktorski
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1173
Adds a warning to instructions on how to install starnet.py on Windows