Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1218: Remove codecov from PR check list #1258

Conversation

Jonatan-Chaverri
Copy link
Contributor

Closes #1218

Introduced changes

  • Disable the Codecov status checks on PRs. This means that Codecov will no longer block PRs from being merged due to coverage decreases or not meeting a certain coverage threshold.
  • Allow Codecov to continue posting comments on PRs with the coverage report. This means that even though Codecov won't block PRs due to coverage issues, you'll still be able to see the impact of the PR on the code coverage in the Codecov comment.

  • This PR contains breaking changes

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75c6b8a) 97.95% compared to head (7c4c169) 97.31%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1258      +/-   ##
===============================================
- Coverage        97.95%   97.31%   -0.65%     
===============================================
  Files               89       89              
  Lines             4506     4506              
===============================================
- Hits              4414     4385      -29     
- Misses              92      121      +29     

see 6 files with indirect coverage changes

@Jonatan-Chaverri
Copy link
Contributor Author

Not sure why tests are failing 🤔 I didn't modify any logic... let me know if there is anything else I need to do.

.github/codecov.yml Outdated Show resolved Hide resolved
@Jonatan-Chaverri
Copy link
Contributor Author

@ddoktorski Done! Please review again. Thanks.

Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

This looks good to me. The failing tests are most likely due to unset secrets for the environment variables in your forked repository. That's fine in this case.

Please feel free to check out other items from the issues list and let us know if you find something interesting to work on :)

@ddoktorski ddoktorski merged commit 580493c into software-mansion:development Jan 23, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify checks.yml workflow to remove Codecov from checks list
2 participants