Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing ABIs with multiple l1_handler entries #1302

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

ddoktorski
Copy link
Collaborator

Closes #1296

Introduced changes

  • Fix bug with parsing an ABI with multiple l1_handler entries
  • Update docs before 0.20.0 release

  • This PR contains breaking changes

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (167e873) to head (83162a7).

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1302      +/-   ##
===============================================
+ Coverage        97.99%   98.01%   +0.02%     
===============================================
  Files               93       93              
  Lines             4582     4580       -2     
===============================================
- Hits              4490     4489       -1     
+ Misses              92       91       -1     
Files Coverage Δ
starknet_py/abi/v2/model.py 100.00% <ø> (ø)
starknet_py/abi/v2/parser.py 94.33% <100.00%> (+0.82%) ⬆️
starknet_py/contract.py 97.68% <100.00%> (ø)

@@ -83,7 +83,7 @@ class Impl:
Constructor
] #: Contract's constructor. It is None if class doesn't define one.
l1_handler: Optional[
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to rename it to l1_handlers but this is a bit problematic given that in some places we use Union[AbiV0, AbiV2], and AbiV0 contains l1_handler, so I decided to retain the same name here.

@ddoktorski ddoktorski merged commit 8754ba0 into development Feb 23, 2024
16 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/1296-fix-abi-l1-handler branch February 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <starknet_py.abi.v2.parser.AbiParsingError>
2 participants