Remove Goerli and migrate network tests on sepolia

[tkumor3]

Closes #

• Remove support for Goerli
• run network test on sepolia

Introduced changes

• This PR contains breaking changes

• Remove StarknetChainId GOERLI

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (8d02f01) to head (71341b8).

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #1328      +/-   ##
===============================================
- Coverage        97.81%   97.74%   -0.07%     
===============================================
  Files               95       95              
  Lines             4752     4750       -2     
===============================================
- Hits              4648     4643       -5     
- Misses             104      107       +3     

Files	Coverage Δ
starknet_py/contract.py	97.68% <ø> (ø)
starknet_py/net/account/account.py	99.59% <ø> (ø)
starknet_py/net/models/chains.py	93.33% <100.00%> (-0.42%)	⬇️
starknet_py/net/networks.py	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[THenry14]

Additional question - I did not check the logs, but I can see network tests are failing. what is the problem?

[tkumor3]

I'm not convinced of this solution, any better idea?

[THenry14]

I'm not sure I understand this change tbh

[tkumor3]

I removed fixture network which was used in a few places. Currently, we need only the devnet URL which can be obtained by calling run_devnet but IMO it's a little bit confusing:

@pytest.fixture(name="client", scope="package")
def create_full_node_client(run_devnet) -> FullNodeClient:
    return FullNodeClient(node_url=run_devnet + "/rpc")

the idea is to assign run_devnet to network and use

@pytest.fixture(name="client", scope="package")
def create_full_node_client(run_devnet) -> FullNodeClient:
    network = run_devnet
    return FullNodeClient(node_url=network + "/rpc")

But tbh I don't like this approach

[THenry14]

what is run_devnets type? is this a function or a string? can we just pass the url, if this is all we need?

[tkumor3]

It's Generator[str, None, None], so if you call run_devnet you will get a string

@pytest.fixture(scope="package")
def run_devnet() -> Generator[str, None, None]:
    """
    Runs devnet instance once per module and returns it's address.
    """
    devnet_port, proc = start_devnet()
    yield f"http://localhost:{devnet_port}"
    proc.kill()

before execute it we don't know devnet port

[ddoktorski]

For me it can be either run_devnet_and_get_url or simply devnet. In the second option, I would pass devnet directly without the assignment network = devnet.

[tkumor3]

devnet sounds good!

[THenry14]

let's do that then