-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split RPC schemas into multiple files #1385
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1385 +/- ##
===============================================
- Coverage 96.64% 87.57% -9.07%
===============================================
Files 95 101 +6
Lines 5005 5079 +74
===============================================
- Hits 4837 4448 -389
- Misses 168 631 +463
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 💪
I've left a few comments. In addition to those, let's also update the migration guide with the information about renamed classes (CompiledContract
and ContractClass
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1316
Introduced changes
transctions.py
trace_api.py
block.py
contract.py
event.py
TODO
This PR contains breaking changes
Move schemas from
gateway.py
torpc.py
Split schemas from
rpc.py
to other files in rpc directoryRename
CompiledContract
,ContractClass
andContractClassSchema
toDeprecatedCompiledContract
,DeprecatedContractClass
andDeprecatedContractClassSchema